Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export project interaction details page #7438

Draft
wants to merge 123 commits into
base: feature/export-project-interactions
Choose a base branch
from

Conversation

paulgain
Copy link
Contributor

@paulgain paulgain commented Dec 27, 2024

Description of change

This PR introduces an export project interaction details page. Currently, there is no backend endpoint available for this page, which will need to be implemented separately. In the interim, this PR uses a locally imported JSON file that mirrors the expected structure of the future endpoint's response.

Once the endpoint is implemented, follow the straightforward instructions provided in src/client/modules/ExportPipeline/ExportInteractionDetails/index.jsx to replace the JSON file with the API response.

Component tests will need to be written after the endpoint is implemented.

Test instructions

Go to: /export/<export-uuid>/interactions/details

Screenshots

Screenshot 2024-12-30 at 10 51 00

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

instead of calling getMessages() arbitrarily
@paulgain paulgain changed the base branch from main to feature/export-project-interactions December 27, 2024 17:13
@paulgain paulgain mentioned this pull request Dec 27, 2024
3 tasks
@paulgain paulgain changed the title Feature/export interaction details Add export project interaction details page Dec 27, 2024
Copy link

cypress bot commented Dec 27, 2024

data-hub-frontend    Run #58926

Run Properties:  status check passed Passed #58926  •  git commit d2487e867d: Moved a constant functions declaration
Project data-hub-frontend
Branch Review feature/export-interaction-details
Run status status check passed Passed #58926
Run duration 01m 40s
Commit git commit d2487e867d: Moved a constant functions declaration
Committer Edmond De Los Reyes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

@paulgain paulgain force-pushed the feature/export-interaction-details branch from adfc563 to 81129a5 Compare December 30, 2024 09:58
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 95.92476% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.58%. Comparing base (f49e4e4) to head (7c75407).

Files with missing lines Patch % Lines
src/client/modules/Companies/MatchCompany/tasks.js 70.00% 3 Missing ⚠️
src/client/components/ContactLocalHeader/index.jsx 84.61% 2 Missing ⚠️
...es/Referrals/SendReferralForm/SendReferralForm.jsx 90.00% 2 Missing ⚠️
.../client/components/ActivityFeed/activities/date.js 94.44% 1 Missing ⚠️
...modules/Contacts/ContactDetails/ConsentDetails.jsx 88.88% 1 Missing ⚠️
src/client/modules/Events/EventDetails/index.jsx 96.66% 1 Missing ⚠️
...ient/modules/Investments/Projects/ProjectTasks.jsx 50.00% 1 Missing ⚠️
src/client/modules/Omis/EditQuoteInformation.jsx 50.00% 1 Missing ⚠️
src/middleware/user-locals.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           feature/export-project-interactions    #7438      +/-   ##
=======================================================================
+ Coverage                                88.55%   88.58%   +0.02%     
=======================================================================
  Files                                     1161     1146      -15     
  Lines                                    18041    17806     -235     
  Branches                                  5129     5098      -31     
=======================================================================
- Hits                                     15977    15773     -204     
+ Misses                                    2064     2033      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

paulgain and others added 23 commits December 30, 2024 12:43
Replace `format` with `formatDate` and clean up unused code
Update test date format to match date format used in component
Bumps [@chromatic-com/storybook](https://github.com/chromaui/addon-visual-tests) from 3.2.2 to 3.2.3.
- [Release notes](https://github.com/chromaui/addon-visual-tests/releases)
- [Changelog](https://github.com/chromaui/addon-visual-tests/blob/main/CHANGELOG.md)
- [Commits](chromaui/addon-visual-tests@v3.2.2...v3.2.3)

---
updated-dependencies:
- dependency-name: "@chromatic-com/storybook"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [react-to-print](https://github.com/MatthewHerbst/react-to-print) from 3.0.2 to 3.0.4.
- [Release notes](https://github.com/MatthewHerbst/react-to-print/releases)
- [Changelog](https://github.com/MatthewHerbst/react-to-print/blob/master/CHANGELOG.md)
- [Commits](MatthewHerbst/react-to-print@v3.0.2...v3.0.4)

---
updated-dependencies:
- dependency-name: react-to-print
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 7.1.0 to 7.1.1.
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/[email protected]/packages/react-router-dom)

---
updated-dependencies:
- dependency-name: react-router-dom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [elastic-apm-node](https://github.com/elastic/apm-agent-nodejs) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/elastic/apm-agent-nodejs/releases)
- [Changelog](https://github.com/elastic/apm-agent-nodejs/blob/main/CHANGELOG.asciidoc)
- [Commits](elastic/apm-agent-nodejs@v4.9.0...v4.10.0)

---
updated-dependencies:
- dependency-name: elastic-apm-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
* WIP: Add overseas region metadata and filter

Co-authored-by: Samuele Mattiuzzo <[email protected]>
…vestments on company activity page (#7415)

* Display EYB activity card and EYB label on linked investments on company activity page

---------

Co-authored-by: Marijn Kampf <[email protected]>
The error occurs because we're invoking history.pushState too frequently,
which exceeds the browser's limit of 100 calls per 10 seconds.

The onPageClick is being called repeatedly in a short time frame
due to a re-render loop which can trigger this error.
…push-state

Fix excessive calls to `window.history.pushState`
paulgain and others added 29 commits January 31, 2025 14:30
Sort a default company export interaction list
Is a best practice to declare constant functions in the beginning of the codebase before calling, in order the javascript interpreter can locate.
@dredmonds dredmonds force-pushed the feature/export-interaction-details branch from 7c75407 to d2487e8 Compare January 31, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.